Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'user' to 'client' #292

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Change 'user' to 'client' #292

merged 3 commits into from
Aug 3, 2023

Conversation

mrsabath
Copy link
Collaborator

No description provided.

@mrsabath mrsabath requested a review from maia-iyer July 20, 2023 01:23
@mrsabath mrsabath marked this pull request as ready for review July 20, 2023 01:23
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add some file deletions - they must have not been added to the commit

Signed-off-by: Mariusz Sabath <[email protected]>
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@mrsabath mrsabath merged commit debd4be into v1.4 Aug 3, 2023
6 checks passed
@mrsabath mrsabath deleted the naming-patch branch August 3, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants